nit: Remove authenticators from state (#70365)

Remove `authenticators` from state because we only set it once
getsentry · May 7, 2024 · 81d3fef · 81d3fef
1 parent 435669b
commit 81d3fef
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/static/app/components/superuserStaffAccessForm.tsx b/static/app/components/superuserStaffAccessForm.tsx
@@ -26,7 +26,6 @@ type Props = {
 };
 
 type State = {
-  authenticators: Array<Authenticator>;
   error: boolean;
   errorType: string;
   isLoading: boolean;
@@ -40,7 +39,6 @@ class SuperuserStaffAccessForm extends Component<Props, State> {
     super(props);
     this.authUrl = this.props.hasStaff ? '/staff-auth/' : '/auth/';
     this.state = {
-      authenticators: [],
       error: false,
       errorType: '',
       showAccessForms: true,
@@ -60,16 +58,17 @@ class SuperuserStaffAccessForm extends Component<Props, State> {
     }
 
     const authenticators = await this.getAuthenticators();
-    this.setState({authenticators: authenticators});
+    this.authenticators = authenticators;
 
     // Set the error state if there are no authenticators and U2F is on
-    if (!authenticators.length && !disableU2FForSUForm) {
+    if (!this.authenticators.length && !disableU2FForSUForm) {
       this.handleError(ErrorCodes.NO_AUTHENTICATOR);
     }
     this.setState({isLoading: false});
   }
 
   authUrl: string;
+  authenticators: Authenticator[] = [];
 
   handleSubmitCOPS = () => {
     this.setState({
@@ -80,13 +79,13 @@ class SuperuserStaffAccessForm extends Component<Props, State> {
 
   handleSubmit = async data => {
     const {api} = this.props;
-    const {superuserAccessCategory, superuserReason, authenticators} = this.state;
+    const {superuserAccessCategory, superuserReason} = this.state;
     const disableU2FForSUForm = ConfigStore.get('disableU2FForSUForm');
 
     const suAccessCategory = superuserAccessCategory || data.superuserAccessCategory;
     const suReason = superuserReason || data.superuserReason;
 
-    if (!authenticators.length && !disableU2FForSUForm) {
+    if (!this.authenticators.length && !disableU2FForSUForm) {
       this.handleError(ErrorCodes.NO_AUTHENTICATOR);
       return;
     }
@@ -193,7 +192,7 @@ class SuperuserStaffAccessForm extends Component<Props, State> {
   }
 
   render() {
-    const {authenticators, error, errorType, showAccessForms, isLoading} = this.state;
+    const {error, errorType, showAccessForms, isLoading} = this.state;
     if (errorType === ErrorCodes.INVALID_SSO_SESSION) {
       this.handleLogout();
       return null;
@@ -212,7 +211,7 @@ class SuperuserStaffAccessForm extends Component<Props, State> {
                 </StyledAlert>
               )}
               <U2fContainer
-                authenticators={authenticators}
+                authenticators={this.authenticators}
                 displayMode="sudo"
                 onTap={this.handleU2fTap}
               />
@@ -240,7 +239,7 @@ class SuperuserStaffAccessForm extends Component<Props, State> {
             {showAccessForms && <Hook name="component:superuser-access-category" />}
             {!showAccessForms && (
               <U2fContainer
-                authenticators={authenticators}
+                authenticators={this.authenticators}
                 displayMode="sudo"
                 onTap={this.handleU2fTap}
               />