Skip to content

Commit

Permalink
chore(stats): Remove project-stats feature flag (#73014)
Browse files Browse the repository at this point in the history
Removes references to the deprecated flag.
  • Loading branch information
leeandher committed Jun 21, 2024
1 parent 66faee2 commit ab2dc61
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 41 deletions.
1 change: 0 additions & 1 deletion src/sentry/api/serializers/models/organization.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@
],
"quotas:new-spike-protection": [
("spike-projections", lambda opt: bool(opt.value)),
("project-stats", lambda opt: bool(opt.value)),
],
}

Expand Down
1 change: 0 additions & 1 deletion src/sentry/apidocs/examples/project_examples.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@
"promotion-be-adoption-enabled",
"monitors",
"am2-billing",
"project-stats",
"profiling-ga",
"performance-new-trends",
"performance-n-plus-one-api-calls-post-process-group",
Expand Down
2 changes: 0 additions & 2 deletions src/sentry/features/temporary.py
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,6 @@ def register_temporary_features(manager: FeatureManager):
manager.add("organizations:project-create-replay-feedback", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
# Limit project events endpoint to only query back a certain number of days
manager.add("organizations:project-event-date-limit", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
# Enable project selection on the stats page
manager.add("organizations:project-stats", OrganizationFeature, FeatureHandlerStrategy.REMOTE, default=True)
# Enable the new Related Events feature
manager.add("organizations:related-events", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
# Enable related issues feature
Expand Down
37 changes: 1 addition & 36 deletions static/app/views/organizationStats/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,12 @@ import PageFiltersContainer from 'sentry/components/organizations/pageFilters/co
import {normalizeDateTimeParams} from 'sentry/components/organizations/pageFilters/parse';
import {ProjectPageFilter} from 'sentry/components/organizations/projectPageFilter';
import SentryDocumentTitle from 'sentry/components/sentryDocumentTitle';
import type {ChangeData} from 'sentry/components/timeRangeSelector';
import {DATA_CATEGORY_INFO, DEFAULT_STATS_PERIOD} from 'sentry/constants';
import {ALL_ACCESS_PROJECTS} from 'sentry/constants/pageFilters';
import {t, tct} from 'sentry/locale';
import ConfigStore from 'sentry/stores/configStore';
import {space} from 'sentry/styles/space';
import type {DataCategoryInfo, DateString, PageFilters} from 'sentry/types/core';
import type {DataCategoryInfo, PageFilters} from 'sentry/types/core';
import type {Organization} from 'sentry/types/organization';
import type {Project} from 'sentry/types/project';
import withOrganization from 'sentry/utils/withOrganization';
Expand All @@ -44,11 +43,6 @@ export const PAGE_QUERY_PARAMS = [
'start',
'end',
'utc',
// TODO(Leander): Remove date selector props once project-stats flag is GA
'pageEnd',
'pageStart',
'pageStatsPeriod',
'pageStatsUtc',
// From data category selector
'dataCategory',
// From UsageOrganizationStats
Expand Down Expand Up @@ -194,12 +188,6 @@ export class OrganizationStats extends Component<OrganizationStatsProps> {
nextState: {
cursor?: string;
dataCategory?: DataCategoryInfo['plural'];
// TODO(Leander): Remove date selector props once project-stats flag is GA
pageEnd?: DateString;
pageStart?: DateString;
pageStatsPeriod?: string | null;
pageStatsUtc?: string | null;
pageUtc?: boolean | null;
query?: string;
sort?: string;
transform?: ChartDataTransform;
Expand Down Expand Up @@ -270,29 +258,6 @@ export class OrganizationStats extends Component<OrganizationStatsProps> {
);
};

// TODO(Leander): Remove the following method once the project-stats flag is GA
handleUpdateDatetime = (datetime: ChangeData): LocationDescriptorObject => {
const {start, end, relative, utc} = datetime;

if (start && end) {
const parser = utc ? moment.utc : moment;

return this.setStateOnUrl({
pageStatsPeriod: undefined,
pageStart: parser(start).format(),
pageEnd: parser(end).format(),
pageUtc: utc ?? undefined,
});
}

return this.setStateOnUrl({
pageStatsPeriod: relative || undefined,
pageStart: undefined,
pageEnd: undefined,
pageUtc: undefined,
});
};

/**
* This method is replaced by the hook "component:enhanced-org-stats"
*/
Expand Down
1 change: 0 additions & 1 deletion tests/sentry/api/serializers/test_organization.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ def test_simple(self):
"minute-resolution-sessions",
"new-page-filter",
"open-membership",
"project-stats",
"relay",
"shared-issues",
"slack-block-kit",
Expand Down

0 comments on commit ab2dc61

Please sign in to comment.