Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow title truncation to be disabled or configured in Slack integration #10811

Open
sgrimm-sg opened this issue Nov 28, 2018 · 11 comments
Open

Comments

@sgrimm-sg
Copy link

Summary

When a notification is sent to Slack via the Slack integration, the title is always truncated to 40 characters and the culprit is included in its entirety. Add a way to either disable title truncation entirely or set the limit to something higher than 40.

Motivation

For some applications, the text of an error is far more useful for initial troubleshooting than the culprit is. For example, in a Java application, I might have code like

log.error("Unable to contact service for destination {}", destinationId);

The Slack notification title gets rendered as,

Unable to contact email service for destinatio - com.mycompany.myservice.common.client.email.aws.AmazonSESClient

In this case the destination is the thing I want to know if I'm monitoring an alerts Slack channel, but it is cut from the Slack message in favor of the fully-qualified class name, which has no length limit.

If the total length of the title has to be limited, I'd much rather lose the package name, or even the entire class name, than any of the message.

The truncation is happening here:

return u'{} - {}'.format(group.title[:40], group.culprit)

@BYK
Copy link
Contributor

BYK commented Oct 21, 2020

Closing this issue due to staleness. Feel free to comment here if you think we should still work on this.

@BYK BYK closed this as completed Oct 21, 2020
@robertpranjic
Copy link

very much needed by our company, +1

@davidwernerhh
Copy link

I think this is an important issue and 40 characters are just not that much really +1

@CevinEichnau
Copy link

same here. need is there +1

@joeyaurel
Copy link

joeyaurel commented Nov 20, 2020

I am also for that the truncation should be removed or be configurable.

I assume that the following line would also be affected by this change:

return u'{} - {}'.format(ev_metadata['type'][:40], group.culprit)

@davidjung1977
Copy link

we really need this +1

@BYK
Copy link
Contributor

BYK commented Nov 23, 2020

Reopening to measure interest and see if we can get this done. PRs also accepted as this seems not too hard.

@BYK BYK reopened this Nov 23, 2020
@BYK BYK added the Easy Task label Nov 23, 2020
@AngelGris
Copy link

I believe this one was fixed in PR 14464

@Pavankumardontha
Copy link

@BYK is this still open ? Can i contribute ?

@hubertdeng123
Copy link
Member

You can contribute whenever you'd like. Seems like this is no longer an issue though

@Pavankumardontha
Copy link

Thanks @hubertdeng123 for your reply. Will work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests