Add timestamp to storage API

[dcramer]

No description provided.

[mfrasca]

you might want to have a look at mfrasca/djang-sentry@35ba710d0d0db60dde0667922cff2770adf6a378

[mfrasca]

you might want to have a look at mfrasca/django-sentry@35ba710d0d0db60dde0667922cff2770adf6a378

[dcramer]

@mfrasca was that just so it could be specified?

I realized that that was going to be a problem after I made those changes. Going to have to look into why TIME_ZONE wouldn't work right with just datetime objs (maybe it needs to use utcnow(), but im not sure that works in all SQL engines)

[mfrasca]

what problems are you observing with TIME_ZONE?

[mfrasca]

I'm reading from this one
http://www.postgresql.org/docs/8.0/static/datatype-datetime.html
and thinking aloud...

• in SQL, timestamps may have a time zone property.
• if you convert timestamp with time zone to datetime, you get a non injective function.
• if you want to convert datetime to timestamp with time zone, you need choose the time zone for the timestamps.
• if we use timestamp without time zone and make sure we are using UTC, things should go fine.

so I'm changing the default from datetime.now to datetime.utcnow.

[dcramer]

Ya I think that's the right change -- need to confirm that wont impact other DB backends (I'll probably just see what auto_now_add does in Django). Gonna get this taken care of this weekend for sure.

[dcramer]

Marking this as fixed