Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack traces not grouping because of jdk.internal.reflect.GeneratedMethodAccessor #13304

Closed
1 of 3 tasks
thyming opened this issue May 21, 2019 · 0 comments · Fixed by #13305
Closed
1 of 3 tasks

Stack traces not grouping because of jdk.internal.reflect.GeneratedMethodAccessor #13304

thyming opened this issue May 21, 2019 · 0 comments · Fixed by #13305

Comments

@thyming
Copy link
Contributor

thyming commented May 21, 2019

Important Details

How are you running Sentry?

  • On-Premise docker [Version 9.0.0]
  • Saas (sentry.io)
  • Other [briefly describe your environment]

Description

Stack traces that should be grouped together, aren't, and the major difference I can see is that they have a stack trace element with the class jdk.internal.reflect.GeneratedMethodAccessor{effectively random number}. This class moved from sun.reflect to jdk.internal.reflect so the fix made in #11145 / e4c6600 doesn't help users of JDK11 (possibly earlier, too).

Steps to Reproduce

  1. Use JDK 11 with some code that uses
  2. Capture an exception that uses Method#invoke somewhere in its call stack.
  3. The captured stack trace will have something like this in it:
    at jdk.internal.reflect.GeneratedMethodAccessor261.invoke
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:566)

What you expected to happen

Ignore the trailing number from the generated method accessor when calculating the grouping for the stacktrace.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant