Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: add mail header to prevent auto replies like out of office #13784

Open
gojufhv opened this issue Jun 24, 2019 · 9 comments
Open

Comments

@gojufhv
Copy link

gojufhv commented Jun 24, 2019

Summary

Sentry sends emails with the sender address configured in config.yml - mail.from. This mailbox receives all auto reply mails like out of office notifications, which are not very useful in this context.

Can you add some mail headers to prevent auto replies on mail notifications?

As far as i know there are basically three different headers which most auto reply filters look for:
X-Auto-Response-Suppress: All
Precedence: Bulk
Auto-Submitted: auto-generated

Motivation

This feature would reduce unwanted mails in the mailbox defined by mail.from.

@BYK
Copy link
Contributor

BYK commented Mar 4, 2021

Ping @getsentry/workflow for triage

@immohsin
Copy link

immohsin commented Jun 1, 2021

@BYK I want to work on this. Can you please point me to appropriate place in the source code.

@BYK
Copy link
Contributor

BYK commented Jun 3, 2021

Hi @immohsin sorry for the late response.

I think you need to add extra_headers to

connection=get_connection(fail_silently=fail_silently),

There's also an example here: https://docs.djangoproject.com/en/3.2/topics/email/

@FayeDel
Copy link

FayeDel commented Oct 1, 2021

Heya!

I know that this is an old/stale issue but may I please work on this?

@BYK
Copy link
Contributor

BYK commented Oct 1, 2021

@DeltaXWizard sure you may!

FayeDel added a commit to FayeDel/sentry that referenced this issue Oct 2, 2021
Add optional header argument from kwargs to positional arguments. This uses Django's header property such that extra headers can be easily given, i.e. the X-Auto-Response-Suppress header

Fixes getsentryGH-13784
@akshatakulkarni25
Copy link

Hello, I'm new to open source and i'm interested in solving this issue.Is this issue still open.Could you please guide me through this issue. Thanks

@Kaushal28
Copy link

@BYK, I want to work on this issue. I saw that the PR is not merged because of lack of test cases. So should I pick this up or is this already fixed?

@BYK
Copy link
Contributor

BYK commented Feb 7, 2023

Hi @Kaushal28, I no longer oversee the efforts here so you may have better luck pinging @chadwhitacre (which I did here now 😅).

That said I think using the old patch and adding tests would be a good start. Also pinging @dashed who reviewed the old PR back in the time in case he has more to add.

@chadwhitacre
Copy link
Member

chadwhitacre commented Feb 7, 2023

Thanks for fielding this @BYK. :)

@Kaushal28 #29029 seems like a good place to start, yes. Good luck! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

7 participants