Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App/root path improvements #3128

Closed
dcramer opened this issue Apr 27, 2016 · 3 comments
Closed

App/root path improvements #3128

dcramer opened this issue Apr 27, 2016 · 3 comments

Comments

@dcramer
Copy link
Member

dcramer commented Apr 27, 2016

Let's improve SDKs and how they handle prefixes and app detection.

  1. Ensure all SDKs have either include_paths (-1) or project_root, which is used to detect in_app
  2. Ensure all SDKs have a list of "prefixes" they can strip. In some cases this can be automatic (Python sys packages, Ruby gems). The project root is automatically included here.
@dcramer
Copy link
Member Author

dcramer commented Apr 27, 2016

@getsentry/team if anyone has feedback here

  • Python has include_paths and auto strips site-packages
  • PHP has "base_path" and "app_path"
  • Ruby assumes relative path for app root + some magic

@dcramer
Copy link
Member Author

dcramer commented Apr 27, 2016

Also converting PHP to "prefixes" for stripping.

@BYK
Copy link
Member

BYK commented Sep 30, 2020

Closing this issue due to staleness. Feel free to comment here if you think we should still work on this.

@BYK BYK closed this as completed Sep 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants