Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Tab tooltip gets hidden at the boundaries of the scrollable area #37238

Closed
ryan953 opened this issue Jul 29, 2022 · 0 comments · Fixed by #38746
Closed

Memory Tab tooltip gets hidden at the boundaries of the scrollable area #37238

ryan953 opened this issue Jul 29, 2022 · 0 comments · Fixed by #38746
Assignees
@danecando

Comments

@ryan953
Copy link
Member

ryan953 commented Jul 29, 2022 •
edited

Not sure how to fix this, we might need to build our own tooltips so they attach to a dom node that's outside of the scrollable area. (maybe there is a config for this in the graph library?)

Image
@ryan953 ryan953 assigned ryan953 and unassigned ryan953 Sep 12, 2022
@danecando danecando self-assigned this Sep 12, 2022
@danecando danecando mentioned this issue Sep 13, 2022
Merged
ryan953 pushed a commit that referenced this issue Sep 15, 2022
@danecando
fix(replays): Memory Chart Tooltip Overflow (#38746)
81573cd 
Configures the Tooltip class to make use of the `appendToBody` field to tooltips can render outside of their containing element. 

Callsites need to set these values: `appendToBody: true, renderMode: 'html', chartId: 'some-id-attr'`

Closes #37238
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@danecando danecando

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(replays): Memory Chart Tooltip Overflow
2 participants
@ryan953 @danecando