Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crons: Add support for multiple environments #42788

Closed
14 tasks done
gaprl opened this issue Jan 4, 2023 · 2 comments
Closed
14 tasks done

Crons: Add support for multiple environments #42788

gaprl opened this issue Jan 4, 2023 · 2 comments
Assignees

Comments

@gaprl
Copy link
Member

gaprl commented Jan 4, 2023

Currently, a Cron Monitor does not support multiple environments such as "production", "development", etc.


Current estimated delivery: 03/22/23

Spec from @evanpurkhiser

We'll need to make some data model updates and adjust some assumptions about how monitors currently store status.

Adding environments means that each checkin entry will now be associated to an environment (or the default empty string).

  1. Monitor status can no longer be denormalized onto the monitor object. The status needs to come from the most recent checkin for the selected environment(s). The status of the monitor will become dependent on the most recent checkin.

  2. Each monitor should have a list of activated environments associated to it. We should introduce a monitorenvironment model that has a FK to the monitor and a FK to the project environment.

  3. next checkin time needs to move to the environment.

  4. Checkin details should be specific to a single environment. It does not make sense to try and show checkins for a monitor across multiple environments.

  5. When listing monitors we should only allow selection of a single environment.

  6. Checkins must now accept the environment for which the checkin is associated to. (If none is passed it should default to production (see environment in the link))

  7. The check_monitors task now needs to take into account each environment as well, so we'll need to update the query to join on the monitor_environments table.

@gaprl gaprl changed the title Add support for multiple environments for a Cron Monitor Crons: Add support for multiple environments Jan 24, 2023
@epicserve
Copy link

When this feature is added, it would be nice if we could set up alerts for just one environment. For example, I would want to get alerted when it's down for production, but I'm not sure I wouldn't want alerts for other environments.

@gaprl
Copy link
Member Author

gaprl commented May 4, 2023

Update from the Crons team: We've successfully rolled out support for multiple environments! 🎉

Here are some instructions per platform:

If you have any questions or issues, feel free to reach out to us at crons-feedback@sentry.io. Thank you.

@gaprl gaprl closed this as completed May 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Beta Availability
Development

No branches or pull requests

5 participants