You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Manual Hub clones can cause scope leakage issues. Also, with the Hub & Scope changes (getsentry/sentry-python#2533), the SDK will no longer have a concept of a Hub, so these clones likely won't do what they were intended to do anymore.
yes, for future reference, the others are all some kind of thread pool executor where you want task level isolation and not thread level (since the same thread will be reused for processing tasks), so we cannot really remove those unless we have first class thread pool integration support.
The hub clone in `download_segment` is unnecessary because the function
is sometimes called from outside a Thread Pool Executor. Since cloning
the hub is only necessary in the Thread Pool Executor, we move the hub
clone there
ClosesGH-63591
Manual Hub clones can cause scope leakage issues. Also, with the Hub & Scope changes (getsentry/sentry-python#2533), the SDK will no longer have a concept of a Hub, so these clones likely won't do what they were intended to do anymore.
See also: https://www.notion.so/sentry/Sentry-SDK-Custom-Code-and-why-we-Should-fix-it-932c8493c29b4bb2bf18c2fc4b729ef1?pvs=4#966901ec61a140f1a18d8f63ba9c7719
Parent issue: #56248
The text was updated successfully, but these errors were encountered: