Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cropping can be challenging #67056

Closed
Tracked by #63749
bruno-garcia opened this issue Mar 15, 2024 · 0 comments · Fixed by getsentry/sentry-javascript#11165
Closed
Tracked by #63749

Cropping can be challenging #67056

bruno-garcia opened this issue Mar 15, 2024 · 0 comments · Fixed by getsentry/sentry-javascript#11165
Assignees
@c298lee

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Mar 15, 2024 •
edited

The new screenshot and cropping is live on NuGet Trends

I found that when using it, it felt challenging to grab the right part of the screen to start cropping:

trimming.mov

It seems like if it's within the screenshot area, it works. But if I'm right on it or slightly off, it doesn't.

Suggestions:

  1. Change cursor when over the the area that allows starting to crop
  2. Allow starting to crop from a radius of the corner. So that even outside of it a bit works out (and cursor would indicate it)
@bruno-garcia bruno-garcia mentioned this issue Mar 15, 2024
Open
@c298lee c298lee self-assigned this Mar 15, 2024
@c298lee c298lee mentioned this issue Mar 18, 2024
Merged
c298lee added a commit to getsentry/sentry-javascript that referenced this issue Mar 18, 2024
@c298lee
fix(feedback): Smoother cropping experience and better UI (#11165)
a99f260 
Fixes some cropping jank:
1. Cropping is smoother: previously the event listeners weren't working
when the mouse was on the cropping buttons, which was causing the
jankiness
2. Changes the cursor when on the cropping buttons
3. Increased the minimum size required for cropping so it's easier to
resize


https://github.com/getsentry/sentry-javascript/assets/55311782/71b7401e-c9f2-44c2-9f92-64c1c80d24ef

Fixes getsentry/sentry#67056
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this issue Apr 19, 2024
@c298lee @cadesalaberry
fix(feedback): Smoother cropping experience and better UI (getsentry#…
dd9397f 
…11165)

Fixes some cropping jank:
1. Cropping is smoother: previously the event listeners weren't working
when the mouse was on the cropping buttons, which was causing the
jankiness
2. Changes the cursor when on the cropping buttons
3. Increased the minimum size required for cropping so it's easier to
resize


https://github.com/getsentry/sentry-javascript/assets/55311782/71b7401e-c9f2-44c2-9f92-64c1c80d24ef

Fixes getsentry/sentry#67056
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@c298lee c298lee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(feedback): Smoother cropping experience and better UI getsentry/sentry-javascript
2 participants
@bruno-garcia @c298lee