Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple bugs due to outdated react-mentions being used in Sentry comments box #67856

Closed
GaurangTandon opened this issue Mar 28, 2024 · 2 comments · Fixed by #69559
Closed

Multiple bugs due to outdated react-mentions being used in Sentry comments box #67856

GaurangTandon opened this issue Mar 28, 2024 · 2 comments · Fixed by #69559

Comments

@GaurangTandon
Copy link

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Visit any issue activity page: https://<X>.sentry.io/issues/<ID>/activity
  2. Click into comments textbox and typed "abcd"
  3. Click outside the textbox into a blank area
  4. Press Cmd+Z

This is a known issue in react-mentions, see signavio/react-mentions@4ef52dd and it got fixed in version 4.4.10, released in June 2023 (https://www.npmjs.com/package/react-mentions?activeTab=versions).

Since the version 4.4.2 (which is the version sentry currently uses:

"react-mentions": "4.4.2",
), react-mentions has fixed several issues like the one above (see changelog: https://github.com/signavio/react-mentions/blob/master/CHANGELOG.md). It would be nice if we could upgrade this dependency to the latest

Expected Result

The latest change is undone, the textbox becomes empty or its value becomes "abc".

Actual Result

Value becomes "abcabcd".

Product Area

Issues

Link

No response

DSN

No response

Version

No response

@getsantry
Copy link
Contributor

getsantry bot commented Mar 28, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Mar 28, 2024

Routing to @getsentry/product-owners-issues for triage ⏲️

@scttcper scttcper self-assigned this Mar 28, 2024
scttcper added a commit that referenced this issue Apr 24, 2024
- updates react-mention fixes #67856
- resolves duplicate babel runtime package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants