Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Replay Details - Breadcrumbs] Introduce new category system for mobile (orientation change, batter status change, etc.) #69226

Closed
Tracked by #70065
romtsn opened this issue Apr 18, 2024 · 2 comments · Fixed by #70265
Closed
Tracked by #70065

[Replay Details - Breadcrumbs] Introduce new category system for mobile (orientation change, batter status change, etc.) #69226

romtsn opened this issue Apr 18, 2024 · 2 comments · Fixed by #70265

Comments

@romtsn
Copy link
Member

romtsn commented Apr 18, 2024 •
edited by michellewzhang

  • Title could be System
  • Description:
    • We could either take it from message (where the SDKs would concatenate details about the breadcrumb into a string)
    • Or we could take the json component from the breadcrumbs component and display the entire data field:

image

We could also reuse the icon we have in the breadcrumbs component
image
@romtsn romtsn mentioned this issue Apr 18, 2024
Open
@romtsn
Copy link
Member Author

romtsn commented Apr 22, 2024

Let's send everything for now, and enable the Console tab for mobile (only internally), all "other" breadcrumbs will show up there. As we develop, we can decide which breadcrumb types are important enough to support properly in the Breadcrumbs tab (e.g. orientation change, battery status, etc.)

@michellewzhang
Copy link
Member

michellewzhang commented Apr 22, 2024 •
edited

@romtsn let's go with this option: "we could take the json component from the breadcrumbs component and display the entire data field"

@bruno-garcia bruno-garcia mentioned this issue May 1, 2024
Open
@michellewzhang michellewzhang mentioned this issue May 3, 2024
Merged
michellewzhang added a commit that referenced this issue May 3, 2024
@michellewzhang
feat(replay): add device breadcrumbs (#70265)
bbae99f 
- closes #69226
- adds 3 new device related breadcrumbs: `connectivity`, `battery`, and
`orientation`
- open to ideas on different logos / messages we could show in the
breadcrumb -- I just kept it simple for now

<img width="429" alt="SCR-20240503-kmns"
src="https://github.com/getsentry/sentry/assets/56095982/6f547d7f-22fd-41d2-8021-34c45025a013">
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(replay): add device breadcrumbs getsentry/sentry
2 participants
@romtsn @michellewzhang