Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Replay Details - UI] Reflect pause/resume for mobile playback #69249

Closed
Tracked by #70065
romtsn opened this issue Apr 18, 2024 · 1 comment
Closed
Tracked by #70065

[Replay Details - UI] Reflect pause/resume for mobile playback #69249

romtsn opened this issue Apr 18, 2024 · 1 comment

Comments

@romtsn
Copy link
Member

romtsn commented Apr 18, 2024

Because we pause/resume replay when an app goes foreground/background, we should reflect this somehow on the playback (e.g. gray out the video view and also the replay timeline part of it). We could do that based off of the breadcrumb that the SDKs send.

Currently these breadcrumbs have:

  • category: navigation
  • data["state"]: foreground|background

Open question: is this breadcrumb data sufficient or should we introduce a new category/type or add more data?

@romtsn romtsn changed the title [Replay Details - Breadcrumbs] Reflect pause/resume for mobile playback [Replay Details - UI] Reflect pause/resume for mobile playback Apr 18, 2024
@michellewzhang
Copy link
Member

michellewzhang commented Apr 22, 2024

  • ui.blur & ui.focus exist for web replays but we don't display them. we could reuse these for mobile; they correlate to background & foreground
  • would be helpful to show, visually in the timeline and possibly an overlay on the video, where there are "gaps" (which likely result from switching from foreground/background)
    • would require a large amount of refactoring wrt the scrubber (e.g. we'd probably want to disable clicking into a gap)

will need to chat with @Jesse-Box on design thoughts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants