Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspect Commit discrepancies #70615

Open
armenzg opened this issue May 9, 2024 · 3 comments
Open

Suspect Commit discrepancies #70615

armenzg opened this issue May 9, 2024 · 3 comments

Comments

@armenzg
Copy link
Member

armenzg commented May 9, 2024

The root of the problem is that somehow the Slack notifications and the UI are fetching the data differently.

The UI gets the list of committers from this API: https://us.sentry.io/api/0/projects/sentry/sentry/events/d6d5d807c0d9449d827e004623246900/committers/

@malwilley was one of the last people touching this area.

We would have to determine how the Slack alert gets the suspect commit.

Which suspect commit would have been the better pick?

If we load this issue we will see this suspect commit (#69211 to PR):
image

If we look at the alert we received in Slack we will see this suspect commit (link to PR):
image

The stack trace is this:
image

Yagiz's change is the suspect commit because base.py was recently changed from the stack trace, however, the change was from load_json_body rather than dispatch (which is part of the stack trace), thus, it should not have been considered a suspect commit:

From Yagiz's change:
image
This shows that the function dispatch is part of the stack trace:
image

Snigdha's change does touch the put function from organization_group_index.py, thus, it makes more sense to blame it:
image
image

@getsantry
Copy link
Contributor

getsantry bot commented May 10, 2024

Routing to @getsentry/product-owners-alerts for triage ⏲️

@ceorourke
Copy link
Member

Cathy's working on this in #70634

@cathteng
Copy link
Member

The suspect commit is processed async so it's not guaranteed to exist by the time the Slack notification is sent. I added logic to fetch it via GroupOwner if it exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants