You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@malwilley was one of the last people touching this area.
We would have to determine how the Slack alert gets the suspect commit.
Which suspect commit would have been the better pick?
If we load this issue we will see this suspect commit (#69211 to PR):
If we look at the alert we received in Slack we will see this suspect commit (link to PR):
The stack trace is this:
Yagiz's change is the suspect commit because base.py was recently changed from the stack trace, however, the change was from load_json_body rather than dispatch (which is part of the stack trace), thus, it should not have been considered a suspect commit:
From Yagiz's change:
This shows that the function dispatch is part of the stack trace:
Snigdha's change does touch the put function from organization_group_index.py, thus, it makes more sense to blame it:
The text was updated successfully, but these errors were encountered:
The suspect commit is processed async so it's not guaranteed to exist by the time the Slack notification is sent. I added logic to fetch it via GroupOwner if it exists
The root of the problem is that somehow the Slack notifications and the UI are fetching the data differently.
The UI gets the list of committers from this API: https://us.sentry.io/api/0/projects/sentry/sentry/events/d6d5d807c0d9449d827e004623246900/committers/
@malwilley was one of the last people touching this area.
We would have to determine how the Slack alert gets the suspect commit.
Which suspect commit would have been the better pick?
If we load this issue we will see this suspect commit (#69211 to PR):
If we look at the alert we received in Slack we will see this suspect commit (link to PR):
The stack trace is this:
Yagiz's change is the suspect commit because base.py was recently changed from the stack trace, however, the change was from
load_json_body
rather thandispatch
(which is part of the stack trace), thus, it should not have been considered a suspect commit:From Yagiz's change:
This shows that the function
dispatch
is part of the stack trace:Snigdha's change does touch the
put
function fromorganization_group_index.py
, thus, it makes more sense to blame it:The text was updated successfully, but these errors were encountered: