Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to load Tag Details for some Issues #71461

Closed
kpujjigit opened this issue May 23, 2024 · 2 comments · Fixed by #71474
Closed

Unable to load Tag Details for some Issues #71461

kpujjigit opened this issue May 23, 2024 · 2 comments · Fixed by #71474

Comments

@kpujjigit
Copy link

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

Select 'Tags' for a particular Issue. This affects some but not all.

Expected Result

Tag Details should appear.

Actual Result

Tags fail to load:
image

Seems Inconsistent Handling of IPv6 Addresses blocks users from viewing Tags in Issue Stream, per initial triage.

Product Area

Issues

Link

No response

DSN

No response

Version

No response

@getsantry
Copy link
Contributor

getsantry bot commented May 23, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented May 23, 2024

Routing to @getsentry/product-owners-issues for triage ⏲️

leeandher added a commit that referenced this issue May 24, 2024
…71474)

Resolves #71461

Prior, when filtering by IP, regardless of which type the address was,
we'd apply an IPv4 and IPv6 filter (`toIPv4` and `toIPv6`). For v4s this
works fine since the `toIPv4` resolves and `toIPv6` allows for passing
v4s. When passing in v6s though, `toIPv4` fails loudly and returns a 500
from the API.

Now, we'll just create two conditions (v4 and v6) and add in all the
valid IPs for each form of address after validating them as one or the
other. The code was also a bit confusing so it got a heavy refactor, and
a few test changes.
volokluev pushed a commit that referenced this issue May 28, 2024
…71474)

Resolves #71461

Prior, when filtering by IP, regardless of which type the address was,
we'd apply an IPv4 and IPv6 filter (`toIPv4` and `toIPv6`). For v4s this
works fine since the `toIPv4` resolves and `toIPv6` allows for passing
v4s. When passing in v6s though, `toIPv4` fails loudly and returns a 500
from the API.

Now, we'll just create two conditions (v4 and v6) and add in all the
valid IPs for each form of address after validating them as one or the
other. The code was also a bit confusing so it got a heavy refactor, and
a few test changes.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants