fix(tags): Allow filtering by both IPv4 and IPv6 tags on EventUsers #71474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
this has annoyed me in the past :D great stuff |
leeandher
force-pushed
the
leander/tags-error-hg-71461
branch
from
8c6d6c0
to
6f6b6d5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #71474 +/- ##
===========================================
+ Coverage 56.81% 77.93% +21.11%
===========================================
Files 6525 6546 +21
Lines 290627 291202 +575
Branches 50287 50373 +86
===========================================
+ Hits 165133 226949 +61816
+ Misses 120765 58004 -62761
- Partials 4729 6249 +1520
|
wedamija
approved these changes
May 23, 2024
volokluev
pushed a commit
that referenced
this pull request
May 28, 2024
…71474) Resolves #71461 Prior, when filtering by IP, regardless of which type the address was, we'd apply an IPv4 and IPv6 filter (`toIPv4` and `toIPv6`). For v4s this works fine since the `toIPv4` resolves and `toIPv6` allows for passing v4s. When passing in v6s though, `toIPv4` fails loudly and returns a 500 from the API. Now, we'll just create two conditions (v4 and v6) and add in all the valid IPs for each form of address after validating them as one or the other. The code was also a bit confusing so it got a heavy refactor, and a few test changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #71461
Prior, when filtering by IP, regardless of which type the address was, we'd apply an IPv4 and IPv6 filter (
toIPv4andtoIPv6). For v4s this works fine since thetoIPv4resolves andtoIPv6allows for passing v4s. When passing in v6s though,toIPv4fails loudly and returns a 500 from the API.Now, we'll just create two conditions (v4 and v6) and add in all the valid IPs for each form of address after validating them as one or the other. The code was also a bit confusing so it got a heavy refactor, and a few test changes.