Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 popovers on hover instead of one #64553

Closed
dalnoki opened this issue Feb 5, 2024 · 9 comments · Fixed by #71501
Closed

2 popovers on hover instead of one #64553

dalnoki opened this issue Feb 5, 2024 · 9 comments · Fixed by #71501
Assignees
@0Calories
Labels
Product Area: Discover

Comments

@dalnoki
Copy link
Contributor

dalnoki commented Feb 5, 2024

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Go to the Discover page of an organization that is on the Team plan
  2. Hover over the Export All button then you'll see the following:
Screenshot 2024-02-05 at 12 42 23

Expected Result

Only the 'Requires Business plan' popover should be visible as this functionality is disabled on the Team plan

Actual Result

Screenshot 2024-02-05 at 12 42 23

Product Area

Other

Link

No response

DSN

No response

Version

No response
@getsantry
Copy link
Contributor

getsantry bot commented Feb 5, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Feb 5, 2024

Routing to @getsentry/product-owners-discover for triage ⏲️

@k-fish
Copy link
Member

k-fish commented Feb 5, 2024

@dalnoki thanks for letting us know, we'll be taking a look soon!

@onkardeshpande93 onkardeshpande93 mentioned this issue Mar 30, 2024
Closed
@onkardeshpande93
Copy link
Contributor

I came across this as well, and when trying to create an issue before the pr, found this one, so plus one to this from me.
You need to be on a non team / business plan and have minimal transactions (<50) to reproduce this.
Sentry saas > discover > bottom table > export btn

@k-fish
Copy link
Member

k-fish commented Apr 2, 2024

@onkardeshpande93 can you let us know if you're on SaaS or self hosted?

@onkardeshpande93 onkardeshpande93 mentioned this issue May 24, 2024
Merged
@sashaboi
Copy link

@k-fish i am on the saas version

@k-fish
Copy link
Member

k-fish commented May 29, 2024

@sashaboi thanks, I thought we had fixed this, I'll take another look

@onkardeshpande93
Copy link
Contributor

Here's the new pr , seems to pass all tests as well #71501

@k-fish
Copy link
Member

k-fish commented Jun 3, 2024

@onkardeshpande93 ah right 😄 , I remembered someone already looking at this but forgot you had put a PR up. I'll update your PR branch, let's see if we can get that merged.

k-fish pushed a commit that referenced this issue Jun 6, 2024
@onkardeshpande93
fix: double tooltips shown on discover export button (#71501)
f96393d 
Fixes #64553

Export button shows the Feature gate tooltip as well as the small export
size tooltip.
Should not show the small export size tooltip if Feature is not
available.
MichaelSun48 pushed a commit that referenced this issue Jun 6, 2024
@onkardeshpande93 @MichaelSun48
fix: double tooltips shown on discover export button (#71501)
0cd5358 
Fixes #64553

Export button shows the Feature gate tooltip as well as the small export
size tooltip.
Should not show the small export size tooltip if Feature is not
available.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@0Calories 0Calories

Labels
Product Area: Discover
Projects
GitHub Issues with 👀 2
Archived in project
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
6 participants
@k-fish @0Calories @dalnoki @sashaboi @Fwang36 @onkardeshpande93