Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double tooltips shown on discover export button #67985

Conversation

onkardeshpande93
Copy link
Contributor

Fixes #64553

Export button shows the Feature gate tooltip as well as the small export size tooltip.
Should not show the small export size tooltip if Feature is not available.

Quick help : I couldn't seem to run the prettier / linter properly for some reason nor do i see how to set those up for this project in the contributing section or the readme, please forgive me if i break any linting tests.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@onkardeshpande93 onkardeshpande93 requested a review from a team as a code owner March 30, 2024 14:49
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 30, 2024
Copy link
Member

@k-fish k-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@getsantry
Copy link
Contributor

getsantry bot commented Apr 30, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Apr 30, 2024
@gggritso
Copy link
Member

@onkardeshpande93 try running yarn lint! It should apply the right formatting

@getsantry getsantry bot closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 popovers on hover instead of one
3 participants