Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(slack): track response_urls in send_slack_response #73087

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

cathteng
Copy link
Member

Small refactor for the send_slack_response. Also adds back the response_url when initializing the params as IdentityParams, so we can properly log the kinds of response_urls we're getting.

@cathteng cathteng requested review from iamrajjoshi and a team June 20, 2024 22:12
@cathteng cathteng requested a review from a team as a code owner June 20, 2024 22:12
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.98%. Comparing base (20a5209) to head (61b1f26).
Report is 8 commits behind head on master.

Current head 61b1f26 differs from pull request most recent head 79d6289

Please upload reports for the commit 79d6289 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #73087      +/-   ##
==========================================
- Coverage   77.98%   77.98%   -0.01%     
==========================================
  Files        6619     6621       +2     
  Lines      295439   295480      +41     
  Branches    50890    50892       +2     
==========================================
+ Hits       230393   230416      +23     
- Misses      58771    58793      +22     
+ Partials     6275     6271       -4     
Files Coverage Δ
...c/sentry/integrations/slack/views/link_identity.py 69.33% <100.00%> (-8.00%) ⬇️
...sentry/integrations/slack/views/unlink_identity.py 77.61% <100.00%> (-4.48%) ⬇️
...s/integrations/slack/link_slack_user_identities.py 86.95% <100.00%> (+0.28%) ⬆️
...c/sentry/integrations/slack/utils/notifications.py 79.12% <42.85%> (-8.66%) ⬇️

... and 10 files with indirect coverage changes

@cathteng cathteng merged commit dc3ad83 into master Jun 21, 2024
48 checks passed
@cathteng cathteng deleted the cathy/slack/track-response-urls branch June 21, 2024 00:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants