Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore GeneratedMethodAccessor suffix #13305

Merged
merged 3 commits into from
May 21, 2019
Merged

Ignore GeneratedMethodAccessor suffix #13305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd466f9
Ignore GeneratedMethodAccessor suffix
thyming May 21, 2019
a5232ec
Ignore GeneratedMethodAccessor suffix in legacy strategy
thyming May 21, 2019
170aa29
test(grouping): Added test for new java generated method accessor
mitsuhiko May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sentry/grouping/strategies/legacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ def remove_module_outliers_legacy(module, platform):
if platform == 'java':
if module[:35] == 'sun.reflect.GeneratedMethodAccessor':
return 'sun.reflect.GeneratedMethodAccessor', 'removed reflection marker'
if module[:44] == 'jdk.internal.reflect.GeneratedMethodAccessor':
return 'jdk.internal.reflect.GeneratedMethodAccessor', 'removed reflection marker'
old_module = module
module = _java_reflect_enhancer_re.sub(r'\1<auto>', module)
module = _java_cglib_enhancer_re.sub(r'\1<auto>', module)
Expand Down
5 changes: 5 additions & 0 deletions src/sentry/grouping/strategies/newstyle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,11 @@ def get_module_component_v1(abs_path, module, platform):
values=['sun.reflect.GeneratedMethodAccessor'],
hint='removed reflection marker',
)
elif module[:44] == 'jdk.internal.reflect.GeneratedMethodAccessor':
module_component.update(
values=['jdk.internal.reflect.GeneratedMethodAccessor'],
hint='removed reflection marker',
)
else:
old_module = module
module = _java_reflect_enhancer_re.sub(r'\1<auto>', module)
Expand Down
4 changes: 4 additions & 0 deletions tests/sentry/grouping/grouping_inputs/frame-ignores-sun-java-generated-methods.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
{
"function": "invoke",
"module": "sun.reflect.GeneratedMethodAccessor12345"
},
{
"function": "invoke",
"module": "jdk.internal.reflect.GeneratedMethodAccessor12345"
}
]
},
Expand Down
14 changes: 12 additions & 2 deletions ...st_event_hash_variant/combined:2019_04_07/frame_ignores_sun_java_generated_methods.pysnap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
created: '2019-04-07T10:03:31.262050Z'
created: '2019-05-21T19:16:08.166809Z'
creator: sentry
source: tests/sentry/grouping/test_variants.py
---
Expand All @@ -13,9 +13,14 @@ app:
'sun.reflect.GeneratedMethodAccessor'
function*
u'invoke'
frame* (frame considered in-app because no frame is in-app)
module* (removed reflection marker)
'jdk.internal.reflect.GeneratedMethodAccessor'
function*
u'invoke'
--------------------------------------------------------------------------
system:
hash: 'df0a8233b314c542a0b98a4e8865c7b5'
hash: '9bc326575875422d0d4ced3c35d9f916'
component:
system*
stacktrace*
Expand All @@ -24,3 +29,8 @@ system:
'sun.reflect.GeneratedMethodAccessor'
function*
u'invoke'
frame*
module* (removed reflection marker)
'jdk.internal.reflect.GeneratedMethodAccessor'
function*
u'invoke'
14 changes: 12 additions & 2 deletions ...test_event_hash_variant/legacy:2019_03_12/frame_ignores_sun_java_generated_methods.pysnap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
created: '2019-03-14T17:12:37.195959Z'
created: '2019-05-21T19:16:09.511284Z'
creator: sentry
source: tests/sentry/grouping/test_variants.py
---
Expand All @@ -13,9 +13,14 @@ app:
'sun.reflect.GeneratedMethodAccessor'
function*
u'invoke'
frame* (frame considered in-app because no frame is in-app)
module* (removed reflection marker)
'jdk.internal.reflect.GeneratedMethodAccessor'
function*
u'invoke'
--------------------------------------------------------------------------
system:
hash: 'df0a8233b314c542a0b98a4e8865c7b5'
hash: '9bc326575875422d0d4ced3c35d9f916'
component:
system*
stacktrace*
Expand All @@ -24,3 +29,8 @@ system:
'sun.reflect.GeneratedMethodAccessor'
function*
u'invoke'
frame*
module* (removed reflection marker)
'jdk.internal.reflect.GeneratedMethodAccessor'
function*
u'invoke'
14 changes: 12 additions & 2 deletions ...st_event_hash_variant/newstyle:2019_04_05/frame_ignores_sun_java_generated_methods.pysnap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
created: '2019-03-15T11:58:33.017753Z'
created: '2019-05-21T19:16:10.811034Z'
creator: sentry
source: tests/sentry/grouping/test_variants.py
---
Expand All @@ -13,9 +13,14 @@ app:
'sun.reflect.GeneratedMethodAccessor'
function*
u'invoke'
frame (non app frame)
module* (removed reflection marker)
'jdk.internal.reflect.GeneratedMethodAccessor'
function*
u'invoke'
--------------------------------------------------------------------------
system:
hash: 'df0a8233b314c542a0b98a4e8865c7b5'
hash: '9bc326575875422d0d4ced3c35d9f916'
component:
system*
stacktrace*
Expand All @@ -24,3 +29,8 @@ system:
'sun.reflect.GeneratedMethodAccessor'
function*
u'invoke'
frame*
module* (removed reflection marker)
'jdk.internal.reflect.GeneratedMethodAccessor'
function*
u'invoke'
14 changes: 12 additions & 2 deletions ...st_event_hash_variant/newstyle:2019_04_17/frame_ignores_sun_java_generated_methods.pysnap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
created: '2019-04-17T20:07:50.420285Z'
created: '2019-05-21T19:16:12.157909Z'
creator: sentry
source: tests/sentry/grouping/test_variants.py
---
Expand All @@ -13,9 +13,14 @@ app:
'sun.reflect.GeneratedMethodAccessor'
function*
u'invoke'
frame (non app frame)
module* (removed reflection marker)
'jdk.internal.reflect.GeneratedMethodAccessor'
function*
u'invoke'
--------------------------------------------------------------------------
system:
hash: 'df0a8233b314c542a0b98a4e8865c7b5'
hash: '9bc326575875422d0d4ced3c35d9f916'
component:
system*
stacktrace*
Expand All @@ -24,3 +29,8 @@ system:
'sun.reflect.GeneratedMethodAccessor'
function*
u'invoke'
frame*
module* (removed reflection marker)
'jdk.internal.reflect.GeneratedMethodAccessor'
function*
u'invoke'
14 changes: 12 additions & 2 deletions ...st_event_hash_variant/newstyle:2019_05_08/frame_ignores_sun_java_generated_methods.pysnap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
created: '2019-05-08T07:29:42.288933Z'
created: '2019-05-21T19:16:13.403893Z'
creator: sentry
source: tests/sentry/grouping/test_variants.py
---
Expand All @@ -13,9 +13,14 @@ app:
'sun.reflect.GeneratedMethodAccessor'
function*
u'invoke'
frame (non app frame)
module* (removed reflection marker)
'jdk.internal.reflect.GeneratedMethodAccessor'
function*
u'invoke'
--------------------------------------------------------------------------
system:
hash: 'df0a8233b314c542a0b98a4e8865c7b5'
hash: '9bc326575875422d0d4ced3c35d9f916'
component:
system*
stacktrace*
Expand All @@ -24,3 +29,8 @@ system:
'sun.reflect.GeneratedMethodAccessor'
function*
u'invoke'
frame*
module* (removed reflection marker)
'jdk.internal.reflect.GeneratedMethodAccessor'
function*
u'invoke'