Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discover) Fix errors on invalid search queries #16111

Merged
merged 1 commit into from Dec 17, 2019
Merged

Conversation

markstory
Copy link
Member

When we get an invalid filter query we should response with a 400 not a 500.

Fixes SENTRY-DTH

When we get an invalid filter query we should response with a 400 not
a 500.

Fixes SENTRY-DTH
@markstory markstory requested a review from a team December 14, 2019 01:21
Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@markstory markstory merged commit cdc7087 into master Dec 17, 2019
@markstory markstory deleted the fix/sentry-dth branch December 17, 2019 02:04
scefali pushed a commit that referenced this pull request Dec 23, 2019
When we get an invalid filter query we should response with a 400 not
a 500.

Fixes SENTRY-DTH
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants