ref: Use @sentry/react #19366
Merged
ref: Use @sentry/react #19366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
force-pushed
the
abhi/feat/use-sentry-react
branch
from
145eaa8
to
7469eb7
Compare
AbhiPrasad
force-pushed
the
abhi/feat/use-sentry-react
branch
from
64b4061
to
f92b616
Compare
AbhiPrasad
force-pushed
the
abhi/feat/use-sentry-react
branch
from
08e5c57
to
576d24f
Compare
AbhiPrasad
force-pushed
the
abhi/feat/use-sentry-react
branch
from
01cdb3c
to
a805960
Compare
AbhiPrasad
force-pushed
the
abhi/feat/use-sentry-react
branch
from
a805960
to
5f04aca
Compare
AbhiPrasad
force-pushed
the
abhi/feat/use-sentry-react
branch
from
5f04aca
to
1264318
Compare
AbhiPrasad
force-pushed
the
abhi/feat/use-sentry-react
branch
from
e34e618
to
56db117
Compare
billyvg
approved these changes
Jun 25, 2020
| @@ -82,4 +80,6 @@ LoadingIndicator.propTypes = { | |||
| hideSpinner: PropTypes.bool, | |||
| }; | |||
|
|
|||
| export default withProfiler(LoadingIndicator); | |||
| export default withProfiler(LoadingIndicator, { | |||
| hasUpdateSpan: false, | |||
There was a problem hiding this comment.
mmm I can't form words atm, but has doesn't read to me that this is an option for withProfiler... maybe something like includeUpdateSpan?
There was a problem hiding this comment.
updateSpan makes it sound like the profiler will perform an update of a span -- maybe includeUpdates?
There was a problem hiding this comment.
So somethin alongs the lines of:
// If time component is on page should be displayed as a span. True by default.
includeRender?: boolean;
// If component updates should be displayed as spans. True by default.
includeUpdates?: boolean;I like this naming.
There was a problem hiding this comment.
For now I am going to merge this in, but I will make the API changes and come back and update.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As we are preparing to add public docs for https://github.com/getsentry/sentry-javascript/tree/master/packages/react, we figured it would be best to dogfood the react package first with sentry.
@sentry/reactis a superset of the@sentry/browserpackage, with a customProfilercomponent added, as well as anErrorBoundarycomponent out of the box.Implementation
List of changes:
@sentry/browserwith@sentry/reactwithProfilerfrom@sentry/reactFuture
Another PR to add the
@sentry/reactErrorBoundarycomponent.