Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(ui): Convert metric rule create to functional component #29274

Merged
merged 1 commit into from
Oct 13, 2021
Merged

ref(ui): Convert metric rule create to functional component #29274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
53 changes: 25 additions & 28 deletions static/app/views/alerts/incidentRules/create.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import {Component} from 'react';
import {RouteComponentProps} from 'react-router';

import {Organization, Project, Team} from 'app/types';
Expand Down Expand Up @@ -33,40 +32,38 @@ type Props = {
/**
* Show metric rules form with an empty rule. Redirects to alerts list after creation.
*/
class IncidentRulesCreate extends Component<Props> {
handleSubmitSuccess = () => {
const {router} = this.props;
const {orgId} = this.props.params;
function IncidentRulesCreate(props: Props) {
function handleSubmitSuccess() {
const {router} = props;
const {orgId} = props.params;

metric.endTransaction({name: 'saveAlertRule'});
router.push(`/organizations/${orgId}/alerts/rules/`);
};
}

render() {
const {project, eventView, wizardTemplate, sessionId, teams, ...props} = this.props;
const defaultRule = eventView
? createRuleFromEventView(eventView)
: wizardTemplate
? createRuleFromWizardTemplate(wizardTemplate)
: createDefaultRule();
const {project, eventView, wizardTemplate, sessionId, teams, ...otherProps} = props;
const defaultRule = eventView
? createRuleFromEventView(eventView)
: wizardTemplate
? createRuleFromWizardTemplate(wizardTemplate)
: createDefaultRule();

const userTeamIds = teams.filter(({isMember}) => isMember).map(({id}) => id);
const userTeamIds = teams.filter(({isMember}) => isMember).map(({id}) => id);

const projectTeamIds = new Set(project.teams.map(({id}) => id));
const defaultOwnerId = userTeamIds.find(id => projectTeamIds.has(id)) ?? null;
defaultRule.owner = defaultOwnerId && `team:${defaultOwnerId}`;
const projectTeamIds = new Set(project.teams.map(({id}) => id));
const defaultOwnerId = userTeamIds.find(id => projectTeamIds.has(id)) ?? null;
defaultRule.owner = defaultOwnerId && `team:${defaultOwnerId}`;

return (
<RuleForm
onSubmitSuccess={this.handleSubmitSuccess}
rule={{...defaultRule, projects: [project.slug]}}
sessionId={sessionId}
project={project}
userTeamIds={userTeamIds}
{...props}
/>
);
}
return (
<RuleForm
onSubmitSuccess={handleSubmitSuccess}
rule={{...defaultRule, projects: [project.slug]}}
sessionId={sessionId}
project={project}
userTeamIds={userTeamIds}
{...otherProps}
/>
);
}

export default withTeams(IncidentRulesCreate);