ref(dynamic-sampling): Hide error rules behind a feature flag - INGEST-701 #30287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
feat/add-new-dynamic-sampling-feature-flag
to
master
November 30, 2021 10:16
matejminar
approved these changes
Nov 30, 2021
| onUpdateRules={this.handleUpdateRules} | ||
| isErrorPanel | ||
| /> | ||
| {organization.features.includes('filters-and-sampling-error-rules') && ( |
There was a problem hiding this comment.
We usually use <Feature/> component to feature gate something in the markup. 🤷♂️
There was a problem hiding this comment.
sure ... but in this case we don't want to display anything, just hide the feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.