Dockerfile: quote args #35565
Merged
Dockerfile: quote args #35565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
/gcbrun |
armenzg
added a commit
that referenced
this pull request
Jun 21, 2022
…appening In PR #35565 contributed a change that did not have acceptance related changes. A [visual diff](https://github.com/getsentry/sentry/actions/runs/2537386363) executed because this is a PR from a fork. That triggered a visual diff run, however, there were no artifacts generated (as expected), thus, it failed to run successfully.
|
Please rebase once #35863 merges. |
armenzg
added a commit
that referenced
this pull request
Jun 21, 2022
…appening (#35863) In PR #35565 contributed a change that did not have acceptance related changes. A [visual diff](https://github.com/getsentry/sentry/actions/runs/2537386363) executed because this is a PR from a fork. That triggered a visual diff run, however, there were no artifacts generated (as expected), thus, it failed to run successfully.
|
@armenzg Same result, I'm afraid. 🐭 |
There's a problem with the detection of what are the changes involved in this PR: I can merge as an admin to get us over the bump. |
|
wfm, low-risk/priority PR |
|
/gcbrun |
|
Thanks for the patch, @glensc. Sorry for the CI noise. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It bothered me to see that passing args in shell scripts are not quoted against spaces.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.