feat(dynamic-sampling): Add isSendingSource to dynamic-sampling SDK versions endpoint [TET-271]
#37295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SamplingSDKVersionsEndpoint` Add new attribute to dymanic-sampling SDK versions endpoint resolves [TET-271]
github-actions
bot
added
the
Scope: Backend
andriisoldatenko
changed the title
isSendingSource to OrganizationDynamicSamplingSDKVersionsEndpointisSendingSource to dynamic-sampling SDK versions endpoint [TET-271]
andriisoldatenko
commented
Aug 1, 2022
| transaction_name="transaction_source", | ||
| # Only available in transactions, pretend like its a tag so we dont error and just null instead | ||
| discover_name="tags[transaction_source]", | ||
| discover_name="transaction_source", |
There was a problem hiding this comment.
AFAIK transaction_source isn't in the discover dataset, and only in the transactions dataset?
andriisoldatenko
commented
Aug 1, 2022
andriisoldatenko
commented
Aug 1, 2022
| avg_equation = 'count_if(trace.client_sample_rate, notEquals, "") / count()' | ||
| sample_rate_count_if = 'count_if(trace.client_sample_rate, notEquals, "")' | ||
| avg_sample_rate_equation = f"{sample_rate_count_if} / count()" | ||
| transaction_source_count_if = 'count_if(transaction.source, Equals, "unknown")' |
There was a problem hiding this comment.
here i still need clarification, what's our target here.
andriisoldatenko
force-pushed
the
andrii/add-source-info-to-ds-sdk-versions-endpoint
branch
from
123ceb7
to
0a6ada5
Compare
jan-auer
reviewed
Aug 2, 2022
src/sentry/api/endpoints/organization_dynamic_sampling_sdk_versions.py
Outdated
Show resolved
Hide resolved
src/sentry/api/endpoints/organization_dynamic_sampling_sdk_versions.py
Outdated
Show resolved
Hide resolved
…sions.py Co-authored-by: Jan Michael Auer <mail@jauer.org>
…sions.py Co-authored-by: Jan Michael Auer <mail@jauer.org>
andriisoldatenko
force-pushed
the
andrii/add-source-info-to-ds-sdk-versions-endpoint
branch
from
e483790
to
ce259fd
Compare
andriisoldatenko
commented
Aug 3, 2022
andriisoldatenko
commented
Aug 3, 2022
| "project": [self.project.id], | ||
| } | ||
| response = self.do_request(query) | ||
| assert response.status_code == 200, response.content |
There was a problem hiding this comment.
we just need to wait for new snuba version.
There was a problem hiding this comment.
this test rely on this snuba commit getsentry/snuba@9e7b0ec
jan-auer
approved these changes
Aug 4, 2022
andriisoldatenko
deleted the
andrii/add-source-info-to-ds-sdk-versions-endpoint
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new attribute to dynamic-sampling SDK versions
endpoint
OrganizationDynamicSamplingSDKVersionsEndpoint.related snuba PR getsentry/snuba#3020
resolves TET-271