Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling): Process sample format #39106

Merged
merged 15 commits into from Sep 27, 2022
Merged

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Sep 21, 2022

We're creating a common format for all the SDKs using sampling: getsentry/relay#1462. Since the format is slightly different than our existing formats, we need to handle it slightly differently.

src/sentry/profiles/task.py Show resolved Hide resolved
src/sentry/profiles/task.py Outdated Show resolved Hide resolved
src/sentry/profiles/task.py Outdated Show resolved Hide resolved
src/sentry/profiles/task.py Outdated Show resolved Hide resolved
src/sentry/profiles/task.py Outdated Show resolved Hide resolved
src/sentry/profiles/task.py Outdated Show resolved Hide resolved
src/sentry/profiles/task.py Outdated Show resolved Hide resolved
src/sentry/profiles/task.py Outdated Show resolved Hide resolved
src/sentry/profiles/task.py Outdated Show resolved Hide resolved
src/sentry/profiles/task.py Outdated Show resolved Hide resolved
src/sentry/profiles/task.py Outdated Show resolved Hide resolved
src/sentry/profiles/task.py Outdated Show resolved Hide resolved
Copy link
Member

@Zylphrex Zylphrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add some tests for these processing steps when we get a chance

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants