New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perf-issues): Add CLI script for testing detector output #39727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool idea!
@k-fish @mjq-sentry any concerns about this one before I merge it? I don't see how the change in span iteration order would cause any issues, but feeling a little paranoid about it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gggritso nothing stands out to me, just reversing from nm to mn.
Adds a CLI script for testing our detection. Very handy for testing detectors on user-supplied events in JSON format.
N.B.: This makes a small logical change! Instead of iterating through the spans one-by-one, and sending each one to each detector, it iterates through the detectors, and sending the detector spans one-by-one. Subtle change, doesn't change the output.
e.g.,