fix(hc): Have ApiInviteHelper work in region silo #43211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are targeted toward getting all AuthHelper and AuthIdentityHandler code to run with control silo limits. Most availability errors from AuthIdentityHandler are fixed, but we need more work around the Actor model and ApiInviteHelper to make it stable.
Resolves failures in test_auth_organization_login.
Extract organization_service.handle_invite from auth_service.handle_new_membership to run on the region silo. Replace ApiInviteHelper's request attribute with a new InviteDetail dataclass that can be sent as an RPC parameter.
github-actions
bot
added
the
Scope: Backend
markstory
reviewed
Jan 13, 2023
| def get_invite_details(request: Request) -> InviteDetail: | ||
| """Extracts invite details from request session""" | ||
| user = request.user | ||
| primary_email = UserEmail.objects.get_primary_email(user) if isinstance(user, User) else None |
There was a problem hiding this comment.
Longer term we might need to include the primary email address on APIUser as doing additional RPC calls for emails seems expensive.
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract organization_service.handle_invite from auth_service.handle_new_membership to run on the region silo. Replace ApiInviteHelper's request attribute with a new InviteDetail dataclass that can be sent as an RPC parameter.