Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dynamic-sampling): Add decaying function support for latest release boost [TET-624] #43300

Merged
merged 2 commits into from
Jan 17, 2023
Merged

feat(dynamic-sampling): Add decaying function support for latest release boost [TET-624] #43300

merged 2 commits into from
Jan 17, 2023

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Jan 16, 2023 •
edited
Loading

This PR aims at implementing the decayingFn field to the latest release boosting rule. This PR is linked to the decaying function implementation in Relay (getsentry/relay#1692).

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 16, 2023
@iambriccardo iambriccardo marked this pull request as ready for review January 16, 2023 08:52
@iambriccardo iambriccardo requested a review from a team as a code owner January 16, 2023 08:52
@iambriccardo iambriccardo requested review from a team, andriisoldatenko and jjbayer and removed request for a team January 16, 2023 08:52
@iambriccardo iambriccardo changed the title feat(dynamic-sampling): Add decaying function support for latest release boost feat(dynamic-sampling): Add decaying function support for latest release boost [TET-624] Jan 16, 2023
jjbayer
jjbayer approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iambriccardo iambriccardo merged commit 4554432 into master Jan 17, 2023
@iambriccardo iambriccardo deleted the riccardo/feat/decaying-function branch January 17, 2023 11:37
@iambriccardo iambriccardo added the Trigger: Revert add to a merged PR to revert it (skips CI) label Jan 17, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: 6c3d2ff

getsentry-bot added a commit that referenced this pull request Jan 17, 2023
@getsentry-bot @iambriccardo
Revert "feat(dynamic-sampling): Add decaying function support for lat…
6c3d2ff 
…est release boost [TET-624] (#43300)"

This reverts commit 4554432.

Co-authored-by: iambriccardo <15819674+iambriccardo@users.noreply.github.com>
@iambriccardo iambriccardo mentioned this pull request Jan 18, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jjbayer jjbayer jjbayer approved these changes

@andriisoldatenko andriisoldatenko Awaiting requested review from andriisoldatenko

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iambriccardo @getsentry-bot @jjbayer