ref(perf-issues): Increase unc asset duration threshold #43722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After looking at some samples for detected asset thresholds, 200ms is probably too low for the recommendation to compress an asset to actually have a meaningful impact on our users browser performance. Since uncompressed assets already targets relatively large assets, there shouldn't be too much of a dip of detected problems. We can raise this later and see how it affects resolve/ignore rates.
github-actions
bot
added
the
Scope: Backend
DominikB2014
approved these changes
Jan 26, 2023
mikejihbe
pushed a commit
that referenced
this pull request
Feb 6, 2023
### Summary After looking at some samples for detected asset thresholds, 200ms is probably too low for the recommendation to compress an asset to actually have a meaningful impact on our users browser performance. Since uncompressed assets already targets relatively large assets, there shouldn't be too much of a dip of detected problems. We can raise this later and see how it affects resolve/ignore rates.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After looking at some samples for detected asset thresholds, 200ms is probably too low for the recommendation to compress an asset to actually have a meaningful impact on our users browser performance. Since uncompressed assets already targets relatively large assets, there shouldn't be too much of a dip of detected problems. We can raise this later and see how it affects resolve/ignore rates.