-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replays): Add UI to display network request details #46219
Conversation
…th the dragdrop handle
it would be nice to have screenshots and tests :) |
Let's kill the |
static/app/views/replays/detail/network/networkRequestDetails.tsx
Outdated
Show resolved
Hide resolved
static/app/views/replays/detail/network/networkRequestDetails.tsx
Outdated
Show resolved
Hide resolved
…doesnt get covered by tabs in english
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested this with and without feature flags enabled and works great.
New 'Network details' panel. Figma per figma specs
There are a few states so observe in the screen shots, and some followup tasks
Note that:
JSON.parse
, but if that fails you'll just get a stringRelated to getsentry/sentry-javascript#7589
Fixes #46054