Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(escalating-issues): Move functions to centralize helper functions #47586

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

jangjodi
Copy link
Member

@jangjodi jangjodi commented Apr 18, 2023

Move escalating issue forecast helper functions into centralized location

Move save_forecast_per_group and get_forecasts to src/sentry/issues/forecasts.py
Move parse_groups_past_counts to src/sentry/issues/escalating.py since it is related to the snuba query

@jangjodi jangjodi requested a review from a team April 18, 2023 20:32
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 18, 2023
@jangjodi jangjodi requested a review from a team April 18, 2023 20:35
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #47586 (3eb6a44) into master (249acba) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #47586      +/-   ##
==========================================
+ Coverage   80.60%   80.74%   +0.14%     
==========================================
  Files        4762     4763       +1     
  Lines      201390   201395       +5     
  Branches    11618    11618              
==========================================
+ Hits       162332   162623     +291     
+ Misses      38802    38516     -286     
  Partials      256      256              
Impacted Files Coverage Δ
src/sentry/issues/escalating.py 100.00% <100.00%> (ø)
src/sentry/issues/forecasts.py 100.00% <100.00%> (ø)
src/sentry/tasks/weekly_escalating_forecast.py 95.23% <100.00%> (-2.59%) ⬇️

... and 35 files with indirect coverage changes

Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on the forecasts.py module!

@jangjodi jangjodi merged commit 5b1edbc into master Apr 19, 2023
@jangjodi jangjodi deleted the jodi/centralize-escalating-fcns branch April 19, 2023 15:32
@armenzg armenzg added this to the Escalating Issues V1 milestone Apr 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants