move release commits endpoint to organization path

[macqueen]

moves https://docs.sentry.io/api/releases/get-release-commits/

depends on #4775. tests will fail until that can be merged/rebased in because i need OrganizationReleasesBaseEndpoint from that pr.

cc @benvinegar @ckj

[getsentry-bot]

	1 Warning
⚠️	Changes require @getsentry/security sign-off

Security concerns found

• src/sentry/api/endpoints/organization_release_commits.py
• src/sentry/api/endpoints/project_release_commits.py
• src/sentry/api/endpoints/release_commits.py

Generated by 🚫 danger

[mattrobenolt]

This is an API change.

[mattrobenolt]

If we're only serializing the Commit objects instead of the ReleaseCommit, why don't we just query for Commits instead? Seems a bit awkward going through ReleaseCommit just to get that.

You could just do:

Commit.objects.filter(releasecommit__release=release)

And you'll directly have the objects you want. Then the order_by becomes releasecommit__order.

This gives us SQL like:

SELECT "sentry_commit"."id", "sentry_commit"."organization_id", "sentry_commit"."repository_id", "sentry_commit"."key", "sentry_commit"."date_added", "sentry_commit"."author_id", "sentry_commit"."message"
FROM "sentry_commit"
INNER JOIN "sentry_releasecommit" ON (
  "sentry_commit"."id" = "sentry_releasecommit"."commit_id"
)
WHERE "sentry_releasecommit"."release_id" = 1 
ORDER BY "sentry_releasecommit"."order" ASC

Unless I'm missing something here with what you're doing.

[macqueen]

i just did it this way because that's how we were doing it in the project version of this endpoint (see below file). but i can change it in both places

[macqueen]

ok, so that doesn't work because of https://github.com/getsentry/sentry/blob/master/src/sentry/api/paginator.py#L120

like Commit.objects.filter(releasecommit__release=release).order_by('releasecommit__order') works, but the paginator tries to do commit.releasecommit__order which doesn't.

[mattrobenolt]

welp 😢