Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref(generic-metrics): set default for index-tag-values to False #52370

Merged
merged 1 commit into from Jul 6, 2023
Merged

Ref(generic-metrics): set default for index-tag-values to False #52370

merged 1 commit into from Jul 6, 2023

Conversation

john-z-yang
Copy link
Member

Overview

Generic metrics tag values should not be indexed, setting to True as default leads to local sentry instances indexing tag values.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 6, 2023
@john-z-yang john-z-yang marked this pull request as ready for review July 6, 2023 18:03
@john-z-yang john-z-yang enabled auto-merge (squash) July 6, 2023 18:03
@john-z-yang john-z-yang merged commit dbd2bc1 into master Jul 6, 2023
56 checks passed
@john-z-yang john-z-yang deleted the john/no-idx-tag-val branch July 6, 2023 18:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@untitaker untitaker untitaker approved these changes

@lynnagara lynnagara lynnagara approved these changes

@onewland onewland Awaiting requested review from onewland

@ayirr7 ayirr7 Awaiting requested review from ayirr7

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@john-z-yang @untitaker @lynnagara