Add Slack to the list of filtered web crawlers #5285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Can we add a couple tests to cover these?
https://github.com/getsentry/sentry/blob/master/tests/sentry/filters/test_web_crawlers.py
I'd say since these are so easy to test, it'd be worth just piling a few in here.
Again, if not, I'd be happy to take over from here.
src/sentry/filters/web_crawlers.py
Outdated
| # Slack - see https://api.slack.com/robots | ||
| r'Slack', | ||
| # Twitter - see https://dev.twitter.com/cards/getting-started#crawling | ||
| r'Twitterbot', |
There was a problem hiding this comment.
So it seems that this is already being covered by L30 above. No?
There was a problem hiding this comment.
Yup I think you're right! I'll get rid of that.
|
@mattrobenolt got it, I'll throw some tests in there this afternoon. |
rcscott
changed the title
|
@mattrobenolt I removed the Twitter filter and added unit tests. I figured I'd add tests for Twitter as well just to be sure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Slack to the list of filtered web crawlers. Slack lists 3 different user agents for their crawlers and the
Slackregex covers all 3 (https://api.slack.com/robots).Filtering Twitter's crawler was suggested in #5284, but this should already be filtered by the generic
bot[\/\s\)\;]regex. I added tests for this just to ensure that it is actually filtered.Fixes #5284