Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(perf): Remove broken error link #54189

Merged
merged 2 commits into from Aug 8, 2023
Merged

feat(perf): Remove broken error link #54189

merged 2 commits into from Aug 8, 2023

Conversation

silent1mezzo
Copy link
Contributor

Remove the link so people don't try to click on it. This improves #46853 but a more permanent fix is needed.

@silent1mezzo silent1mezzo requested a review from a team as a code owner August 4, 2023 18:11
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 4, 2023
narsaynorath
narsaynorath approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested it locally, but you have some failing typescript tests in traceErrorList.spec.tsx because some of the components are still being assigned an onClickSpan

@silent1mezzo silent1mezzo changed the title Remove broken error link feat(perf): Remove broken error link Aug 4, 2023
@silent1mezzo silent1mezzo merged commit 6aa5c5c into master Aug 8, 2023
51 checks passed
@silent1mezzo silent1mezzo deleted the adammckerlie/remove-error-link branch August 8, 2023 15:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@narsaynorath narsaynorath narsaynorath approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@silent1mezzo @narsaynorath