Streamline kotlin onboarding docs #57342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
Scope: Frontend
lbloder
reviewed
Oct 6, 2023
| additionalInfo: ( | ||
| <p> | ||
| {tct( | ||
| 'To upload your source code to Sentry so it can be shown in stack traces, please refer to [link:Manually Uploading Source Context].', |
There was a problem hiding this comment.
Should we rewrite this to something like:
"If you prefer to manually upload your source code to Sentry, please refer to..." ?
This also applies to the Java wizard.
Or we could simply delete this part, WDYT?
| 'To upload your source code to Sentry so it can be shown in stack traces, please refer to [link:Manually Uploading Source Context].', | ||
| { | ||
| link: ( | ||
| <ExternalLink href="https://docs.sentry.io/platforms/java/source-context/" /> |
There was a problem hiding this comment.
Maybe directly link to the manual steps: https://docs.sentry.io/platforms/java/source-context/#manually-uploading-source-context
There was a problem hiding this comment.
The introduction component (line 55) does not show up correctly. This is due to an open bracket that is not closed. Also, the strong component needs to be duplicated in order to work correctly. Here's my suggestion:
const introduction = (
<p>
{tct(
"Sentry supports Kotlin for both JVM and Android. This wizard guides you through set up in the JVM scenario. If you're interested in [strong:Android], head over to the [gettingStartedWithAndroidLink:Getting Started] for that SDK instead. At its core, Sentry for Java provides a raw client for sending events to Sentry. If you use [strong2:Spring Boot, Spring, Logback, JUL, or Log4j2], head over to our [gettingStartedWithJavaLink:Getting Started for Sentry Java].",
{
gettingStartedWithAndroidLink: (
<ExternalLink href="https://docs.sentry.io/platforms/android/" />
),
gettingStartedWithJavaLink: (
<ExternalLink href="https://docs.sentry.io/platforms/java/" />
),
strong: <strong />,
strong2: <strong />,
}
)}
</p>
);
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last missing piece to close getsentry/sentry-java#2885
Move performance into "Next Steps", Use SAGP and Maven plugin, enable Source Context