Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added metrics summary sample rates as options #60506

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

mitsuhiko
Copy link
Member

This lands a callback which controls the sample rate of span local metric summaries dynamically.

Refs getsentry/sentry-python#2522

@mitsuhiko mitsuhiko requested a review from a team as a code owner November 23, 2023 09:02
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #60506 (b7ac009) into master (f8ba0d6) will increase coverage by 1.02%.
Report is 2 commits behind head on master.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #60506      +/-   ##
==========================================
+ Coverage   79.81%   80.84%   +1.02%     
==========================================
  Files        5180     5181       +1     
  Lines      227644   227772     +128     
  Branches    38305    38330      +25     
==========================================
+ Hits       181702   184146    +2444     
+ Misses      40211    37997    -2214     
+ Partials     5731     5629     -102     
Files Coverage Δ
src/sentry/utils/sdk.py 67.66% <ø> (-0.34%) ⬇️
src/sentry/metrics/minimetrics.py 91.54% <50.00%> (-1.21%) ⬇️

... and 189 files with indirect coverage changes

@mitsuhiko mitsuhiko merged commit 6f033b1 into master Nov 27, 2023
49 of 51 checks passed
@mitsuhiko mitsuhiko deleted the feature/metrics-summary-sample-rate branch November 27, 2023 09:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants