Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perf): Add frames delay to mobile vitals #61349

Closed
wants to merge 1 commit into from

Conversation

philipphofmann
Copy link
Member

Add frames delay as a known mobile measurement.

We need this for sending frames delay with the mobile SDKs: getsentry/team-mobile#160. Otherwise, the transactions show that custom measurement

CleanShot 2023-12-07 at 13 50 34@2x

Add frames delay as a known mobile measurement.
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Dec 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@philipphofmann
Copy link
Member Author

We will add frames delay numbers to span data instead of transaction measurements. We can close this.

@philipphofmann philipphofmann deleted the feat/add-frames-delay-measurement branch December 14, 2023 13:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant