Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spans): Groundwork for indexed spans tests #61766

Merged
merged 1 commit into from Dec 18, 2023
Merged

feat(spans): Groundwork for indexed spans tests #61766

merged 1 commit into from Dec 18, 2023

Conversation

wmak
Copy link
Member

@wmak wmak commented Dec 14, 2023

@wmak
feat(spans): Groundwork for indexed spans tests
fd700d2 
- This sets up the groundwork for writing more indexed spans tests
- Replaces #61387 by using the snuba insert endpoint
@wmak wmak requested a review from a team as a code owner December 14, 2023 17:33
@wmak wmak requested a review from a team December 14, 2023 17:34
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 14, 2023
@wmak wmak mentioned this pull request Dec 14, 2023
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #61766 (fd700d2) into master (67dd30e) will increase coverage by 0.00%.
Report is 9 commits behind head on master.
The diff coverage is 75.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #61766   +/-   ##
=======================================
  Coverage   81.14%   81.15%           
=======================================
  Files        5188     5188           
  Lines      228482   228486    +4     
  Branches    38317    38317           
=======================================
+ Hits       185409   185422   +13     
+ Misses      37441    37435    -6     
+ Partials     5632     5629    -3
Files Coverage Δ
src/sentry/testutils/pytest/fixtures.py 81.35% <ø> (ø)
src/sentry/testutils/cases.py 86.32% <75.00%> (-0.04%) ⬇️

... and 7 files with indirect coverage changes

evanh
evanh reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@evanh evanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wmak wmak merged commit 4a67546 into master Dec 18, 2023
50 of 51 checks passed
@wmak wmak deleted the wmak/feat/groundwork-for-indexed-spans-tests-v2 branch December 18, 2023 23:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanh evanh evanh left review comments

@narsaynorath narsaynorath narsaynorath approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wmak @evanh @narsaynorath