Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ddm): display all code locations #61994

Merged
merged 2 commits into from Dec 19, 2023
Merged

Conversation

obostjancic
Copy link
Member

@obostjancic obostjancic commented Dec 19, 2023

Displays all "frames" of the last code location.
Adds temporary mapping to the intended api response shape (#61995)

closes #62000

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 19, 2023
@obostjancic obostjancic marked this pull request as ready for review December 19, 2023 12:39
@obostjancic obostjancic requested a review from a team as a code owner December 19, 2023 12:39
if (data.metrics) {
return;
}
// @ts-expect-error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here?

// @ts-expect-error: Why we expect the error

@obostjancic obostjancic enabled auto-merge (squash) December 19, 2023 13:55
@obostjancic obostjancic merged commit 69fc164 into master Dec 19, 2023
40 checks passed
@obostjancic obostjancic deleted the ogi/fix/code-location-frames branch December 19, 2023 14:16
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show all code locations in the UI
2 participants