fix(beacon): Events in 24h for now calculated properly #62441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62441 +/- ##
==========================================
+ Coverage 81.21% 81.26% +0.04%
==========================================
Files 5188 5197 +9
Lines 228782 230095 +1313
Branches 38423 39764 +1341
==========================================
+ Hits 185812 186989 +1177
- Misses 37302 37376 +74
- Partials 5668 5730 +62
|
hubertdeng123
commented
Jan 2, 2024
| for organization_id in organization_ids: | ||
| events_per_org_24h = tsdb.backend.get_sums( | ||
| model=TSDBModel.organization_total_received, | ||
| keys=[organization_id], |
There was a problem hiding this comment.
multiple org ids cannot be passed in here
azaslavsky
approved these changes
Jan 2, 2024
26 tasks
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
armenzg
pushed a commit
that referenced
this pull request
Jan 8, 2024
events in last 24 hours were always showing as 0, this fixes that
trillville
pushed a commit
that referenced
this pull request
Jan 19, 2024
events in last 24 hours were always showing as 0, this fixes that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
events in last 24 hours were always showing as 0, this fixes that