feat(ddm-onboarding): Add js server instructions #63189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
obostjancic
approved these changes
Jan 15, 2024
| @@ -409,6 +409,7 @@ const customMetricBackendPlatforms: readonly PlatformKey[] = [ | |||
| ]; | |||
|
|
|||
| const customMetricFrontendPlatforms: readonly PlatformKey[] = [ | |||
There was a problem hiding this comment.
Suggested change
| const customMetricFrontendPlatforms: readonly PlatformKey[] = [ | |
| const customMetricPlatforms: readonly PlatformKey[] = [ |
now that it includes also backend frameworks?
There was a problem hiding this comment.
good catch!
or even better, I could use the existingcustomMetricBackendPlatforms set 😬
ArthurKnaus
deleted the
aknaus/feat/ddm-onboarding/add-js-server-instructions
branch
trillville
pushed a commit
that referenced
this pull request
Jan 19, 2024
Add custom metrics onboarding instructions for the platforms `bun`,`node`,`node-express`,`node-koa`,`node-connect` and `node-azurefunctions`. - closes #63182
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom metrics onboarding instructions for the platforms
bun,node,node-express,node-koa,node-connectandnode-azurefunctions.