Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(api): Make processing team endpoints private #63939

Merged
merged 3 commits into from Feb 8, 2024

Conversation

loewenheim
Copy link
Contributor

This makes the endpoints private that the processing team doesn't think should be public.

@loewenheim loewenheim requested a review from a team as a code owner January 26, 2024 12:23
@loewenheim loewenheim self-assigned this Jan 26, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61f933f) 81.39% compared to head (a286d2f) 81.25%.
Report is 646 commits behind head on master.

❗ Current head a286d2f differs from pull request most recent head 352d20f. Consider uploading reports for the commit 352d20f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #63939      +/-   ##
==========================================
- Coverage   81.39%   81.25%   -0.15%     
==========================================
  Files        5228     5234       +6     
  Lines      232454   230518    -1936     
  Branches    40249    45234    +4985     
==========================================
- Hits       189217   187307    -1910     
+ Misses      37388    37371      -17     
+ Partials     5849     5840       -9     
Files Coverage Δ
src/sentry/api/endpoints/chunk.py 87.95% <ø> (-0.15%) ⬇️
src/sentry/api/endpoints/debug_files.py 83.33% <ø> (-0.07%) ⬇️
...c/sentry/api/endpoints/event_apple_crash_report.py 57.69% <ø> (-1.57%) ⬇️
src/sentry/api/endpoints/event_reprocessable.py 82.60% <ø> (-0.73%) ⬇️
...endpoints/project_app_store_connect_credentials.py 44.84% <ø> (-0.29%) ⬇️
src/sentry/api/endpoints/project_reprocessing.py 85.71% <ø> (-0.96%) ⬇️

... and 2209 files with indirect coverage changes

@@ -180,9 +180,9 @@ def get(self, request: Request, project) -> Response:
class DebugFilesEndpoint(ProjectEndpoint):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just replied in the channel and seems like from Dhrumil's comment we need to keep this one public.

@loewenheim loewenheim enabled auto-merge (squash) February 8, 2024 17:06
@loewenheim loewenheim merged commit d38869a into master Feb 8, 2024
48 checks passed
@loewenheim loewenheim deleted the ref/processing-private-apis branch February 8, 2024 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants