Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update redis and remove redis-py-cluster #64711

Merged
merged 1 commit into from Feb 15, 2024
Merged

build: update redis and remove redis-py-cluster #64711

merged 1 commit into from Feb 15, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 6, 2024

Updates redis to v4.1.0 since it is the minimum Redis version that supports/includes RedisCluster

@anonrig anonrig requested a review from a team as a code owner February 6, 2024 21:52
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 6, 2024
@anonrig anonrig marked this pull request as draft February 6, 2024 21:57
@anonrig anonrig marked this pull request as ready for review February 6, 2024 22:25
@anonrig anonrig requested a review from a team as a code owner February 7, 2024 19:04
asottile-sentry
asottile-sentry reviewed Feb 7, 2024
View reviewed changes
src/sentry/processing/backpressure/memory.py Outdated Show resolved Hide resolved
src/sentry/tsdb/redis.py Outdated Show resolved Hide resolved
@anonrig anonrig force-pushed the update-redis branch 2 times, most recently from 670aa1c to efaa6a7 Compare February 7, 2024 21:11
@anonrig anonrig requested a review from a team as a code owner February 7, 2024 21:11
@anonrig anonrig requested review from a team as code owners February 8, 2024 17:00
asottile-sentry
asottile-sentry approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anonrig
Copy link
Member Author

anonrig commented Feb 9, 2024

Blocked: #64885

@CMDMichalKoval

This comment was marked as spam.

Sign in to view
@anonrig anonrig merged commit 58c2f2c into master Feb 15, 2024
50 checks passed
@anonrig anonrig deleted the update-redis branch February 15, 2024 16:39
@anonrig anonrig added the Trigger: Revert add to a merged PR to revert it (skips CI) label Feb 15, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: c699781

getsentry-bot added a commit that referenced this pull request Feb 15, 2024
@getsentry-bot @anonrig
Revert "build: update redis and remove redis-py-cluster (#64711)"
c699781 
This reverts commit 58c2f2c.

Co-authored-by: anonrig <1935246+anonrig@users.noreply.github.com>
anonrig added a commit that referenced this pull request Feb 15, 2024
@anonrig
Reapply "build: update redis and remove redis-py-cluster (#64711)"
4f6a11b 
This reverts commit c699781.
anonrig added a commit that referenced this pull request Feb 15, 2024
@anonrig
Reapply "build: update redis and remove redis-py-cluster (#64711)"
ec99396 
This reverts commit c699781.
anonrig added a commit that referenced this pull request Feb 15, 2024
@anonrig
Reapply "build: update redis and remove redis-py-cluster (#64711)"
16fb8c7 
This reverts commit c699781.
anonrig added a commit that referenced this pull request Feb 15, 2024
@anonrig
Reapply "build: update redis and remove redis-py-cluster (#64711)"
bf35156 
This reverts commit c699781.
anonrig added a commit that referenced this pull request Feb 15, 2024
@anonrig
Reapply "build: update redis and remove redis-py-cluster (#64711)" (#…
a91ae04 
…65246)
getsentry-bot added a commit that referenced this pull request Feb 15, 2024
@getsentry-bot @Zylphrex
Revert "Reapply "build: update redis and remove redis-py-cluster (#64711
d523ec8 
)" (#65246)"

This reverts commit a91ae04.

Co-authored-by: Zylphrex <10239353+Zylphrex@users.noreply.github.com>
anonrig added a commit that referenced this pull request Feb 15, 2024
@anonrig
Reapply "Reapply "build: update redis and remove redis-py-cluster (#6…
5a91bc6 
…4711)" (#65246)"

This reverts commit d523ec8.
anonrig pushed a commit that referenced this pull request Feb 15, 2024
@getsentry-bot @Zylphrex @anonrig
Revert "Reapply "build: update redis and remove redis-py-cluster (#64711
8c5771a 
)" (#65246)"

This reverts commit a91ae04.

Co-authored-by: Zylphrex <10239353+Zylphrex@users.noreply.github.com>
anonrig added a commit that referenced this pull request Feb 15, 2024
@anonrig
Reapply "Reapply "build: update redis and remove redis-py-cluster (#6…
900b51b 
…4711)" (#65246)"

This reverts commit d523ec8.
anonrig added a commit that referenced this pull request Feb 16, 2024
@anonrig
Reapply "Reapply "build: update redis and remove redis-py-cluster (#6…
e529d87 
…4711)" (#65246)"

This reverts commit d523ec8.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mitsuhiko mitsuhiko mitsuhiko approved these changes

@untitaker untitaker untitaker approved these changes

@vartec vartec vartec approved these changes

@asottile-sentry asottile-sentry asottile-sentry approved these changes

@CMDMichalKoval CMDMichalKoval CMDMichalKoval approved these changes

@beezz beezz Awaiting requested review from beezz

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@anonrig @CMDMichalKoval @getsentry-bot @mitsuhiko @untitaker @vartec @asottile-sentry