Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(issues): Revert-revert of deleting streamline-targeting-context #65160

Merged
merged 6 commits into from Feb 15, 2024

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Feb 14, 2024

Revert-revert of #64876, with the addition of a bug fix caught in canary with #65104

The canary error came from refreshing the schemas after a ProjectOwnership is created, but then raw is set to None. Now it should accept None just fine, espcially since thats a valid value for that field on the model.

todo

  • Add tests

@leeandher leeandher requested review from a team as code owners February 14, 2024 16:24
@leeandher leeandher changed the title chore(issues): Revert-revert of deleting streamline-targeting-context. chore(issues): Revert-revert of deleting streamline-targeting-context Feb 14, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7dba2dc) 55.95% compared to head (72d43db) 81.44%.

❗ Current head 72d43db differs from pull request most recent head 7efd6a9. Consider uploading reports for the commit 7efd6a9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #65160       +/-   ##
===========================================
+ Coverage   55.95%   81.44%   +25.49%     
===========================================
  Files        5242     5254       +12     
  Lines      231800   232126      +326     
  Branches    45455    45501       +46     
===========================================
+ Hits       129702   189064    +59362     
+ Misses      98000    37190    -60810     
- Partials     4098     5872     +1774     
Files Coverage Δ
src/sentry/api/endpoints/codeowners/__init__.py 90.41% <100.00%> (+39.09%) ⬆️
src/sentry/api/endpoints/codeowners/index.py 94.33% <100.00%> (+46.97%) ⬆️
.../sentry/api/serializers/models/projectownership.py 100.00% <100.00%> (+9.52%) ⬆️
src/sentry/apidocs/examples/project_examples.py 100.00% <ø> (ø)
src/sentry/conf/server.py 88.18% <ø> (+0.16%) ⬆️
src/sentry/features/__init__.py 100.00% <ø> (ø)
src/sentry/models/projectcodeowners.py 88.50% <ø> (+37.93%) ⬆️
src/sentry/ownership/grammar.py 96.08% <100.00%> (+71.71%) ⬆️
src/sentry/api/endpoints/project_ownership.py 91.94% <83.33%> (+55.52%) ⬆️
...entry/integrations/slack/message_builder/issues.py 89.45% <57.14%> (+74.25%) ⬆️
... and 1 more

... and 1886 files with indirect coverage changes

@leeandher leeandher merged commit 5f4c34c into master Feb 15, 2024
47 of 48 checks passed
@leeandher leeandher deleted the leander/revert-revert-64876 branch February 15, 2024 15:54
Copy link

sentry-io bot commented Feb 21, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Group.DoesNotExist: Group matching query does not exist. sentry.tasks.digests.deliver_digest View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants