fix(perf): Fix HTTP widget documentation link #66011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is _slightly_ different than the name implies.
- change the copy a bit - redirect to Set Up Performance page - rename variable
github-actions
bot
added
the
Scope: Frontend
|
Thoughts on this adjustment so that it's more actionable but still links to the performance setup? "No transactions with HTTP spans found. You may need to add integrations to your performance monitoring setup to instrument spans." |
|
@vivianyentran I like that! What do you think about "to capture these spans" instead of "to instrument spans"? I think we usually say that spans are "captured", and instrumentation is "added" to a codebase or application |
|
Good suggestion! "Capture spans" definitely makes more sense in this case! |
|
@vivianyentran done 👍🏻 |
aliu3ntry
pushed a commit
that referenced
this pull request
Mar 6, 2024
Fixes #65071 Directs users with no HTTP span to the "Set Up Performance" page rather than the "Integrations" page which doesn't even exist for a lot of platforms.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65071
Directs users with no HTTP span to the "Set Up Performance" page rather than the "Integrations" page which doesn't even exist for a lot of platforms.
Maybe the widget copy is a little awkward?
e.g.,
