feat(processing) Move redis operations in reprocessing to servicewrapper #66168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to shift the reprocessing workload to a new redis cluster without downtime. In order to do that I would like to use our Service wrappers and ServiceDelegator to dual write and then shift reads via runtime options. Before I can move load with ServiceDelegator the existing logic needs to be moved into a service wrapper.
github-actions
bot
added
the
Scope: Backend
markstory
changed the title
anonrig
reviewed
Mar 1, 2024
| import redis | ||
| from django.conf import settings | ||
|
|
||
| from sentry.utils import json |
There was a problem hiding this comment.
I see that you're only using dumps, explicit importing this would be better:
Suggested change
| from sentry.utils import json | |
| from sentry.utils.json import dumps |
| for primary_hash in old_primary_hashes: | ||
| key = _get_old_primary_hash_subset_key(project_id, group_id, primary_hash) | ||
| event_count += client.llen(key) | ||
| if options.get(use_store_option): |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #66168 +/- ##
==========================================
+ Coverage 84.24% 84.26% +0.01%
==========================================
Files 5299 5304 +5
Lines 236744 236906 +162
Branches 40981 40993 +12
==========================================
+ Hits 199442 199625 +183
+ Misses 37083 37062 -21
Partials 219 219
|
anonrig
approved these changes
Mar 4, 2024
untitaker
approved these changes
Mar 5, 2024
aliu3ntry
pushed a commit
that referenced
this pull request
Mar 6, 2024
…per (#66168) We need to shift the reprocessing workload to a new redis cluster without downtime. In order to do that I would like to use our Service wrappers and ServiceDelegator to dual write and then shift reads via runtime options. Before I can move load with ServiceDelegator the existing logic needs to be moved into a service wrapper.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to shift the reprocessing workload to a new redis cluster without downtime. In order to do that I would like to use our Service wrappers and ServiceDelegator to dual write and then shift reads via runtime options.
Before I can move load with ServiceDelegator the existing logic needs to be moved into a service wrapper.